From: Jer Noble <jer.noble@apple.com>
Date: Fri, 7 Dec 2012 22:22:08 +0000 (-0800)
Subject: Fixed TrackHeaderAtom inheritance chain, which was causing a parsing bug. Made the... 
X-Git-Url: http://id.pley.net/movie_parser.git/commitdiff_plain/49dd866a06288856e4a1d5df3f00a6a0fccea2fa?ds=inline;hp=578248d58df5e9cb5c8de2ea7cabff4560db9fa6

Fixed TrackHeaderAtom inheritance chain, which was causing a parsing bug. Made the demo page Firefox compatible.
---

diff --git a/Atom.js b/Atom.js
index 52e9e59..2fc62ef 100644
--- a/Atom.js
+++ b/Atom.js
@@ -332,7 +332,7 @@ var TrackHeaderAtom = function(buffer, offset) {
     this.super(TrackHeaderAtom).constructor.call(this, buffer, offset);
 }
 
-TrackHeaderAtom.prototype = Object.create(Atom.prototype);
+TrackHeaderAtom.prototype = Object.create(VersionFlagsAtom.prototype);
 
 TrackHeaderAtom.prototype.setDefaults = function() {
     this.super(TrackHeaderAtom).setDefaults.call(this);
diff --git a/AtomTester.html b/AtomTester.html
index d0bcbf1..2617264 100644
--- a/AtomTester.html
+++ b/AtomTester.html
@@ -3,6 +3,10 @@
     <title>AtomTester</title>
     <script src=Atom.js></script>
     <script>
+        // Add Blob.prototype.slice if it does not already exist:
+        if (typeof(Blob.prototype.slice) == 'undefined' && typeof(Blob.prototype.webkitSlice) != 'undefined')
+            Blob.prototype.slice = Blob.prototype.webkitSlice;
+
         var moovAtom;
         function onFileSelect(e) {
             var file = e.target.files[0];
@@ -20,7 +24,7 @@
                     else
                         checkForMoovAtom(offset + basicAtom.size);
                 };
-                var subset = file.webkitSlice(offset, offset + 16);
+                var subset = file.slice(offset, offset + 16);
                 reader.readAsArrayBuffer(subset);
             };
             
@@ -30,7 +34,7 @@
                     var output = document.getElementById('output');
                     output.appendChild(toDOMNode(moovAtom));
                 };
-                var subset = file.webkitSlice(offset, offset + length);
+                var subset = file.slice(offset, offset + length);
                 reader.readAsArrayBuffer(subset);
             };
             
@@ -70,7 +74,7 @@
                     continue;
                 var div = document.createElement('div');
                 var dt = document.createElement('dt');
-                dt.innerText = property;
+                dt.appendChild(document.createTextNode(property));
                 var dd = document.createElement('dd');
                 dd.appendChild(toDOMRepresentation(value));
                 div.appendChild(dt);